Repository navigation
fix: point legacy redirects at existing pages - #1660
Merged
LadyBluenotes merged 1 commit intoOct 18, 2026
Merged
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LadyBluenotes
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
Three entries in
src/middleware/legacy-routes-redirect.tsredirect to pages that no longer exist, so visitors following those old links land on the 404 page. This PR updates them to the current pages:/references/api-reference/reactive-utilities/onnow redirects to/reference/reactive-utilities/on-utilinstead of/reference/reactive-utilities/on./routing/migration/now redirects to/solid-router/guides/migrationinstead of/routing/migration./guides/how-to-guides/routing-in-solid/solid-routernow redirects to/solid-router/getting-started/installation-and-setupinstead of/routing/installation-and-setup.It also adds
/routing/migration(without the trailing slash) so that old URL reaches the migration guide too.Verification:
LEGACY_ROUTESthroughhandleLegacyRoutesand checks its target againstsrc/routes. Before: 87 resolve and 3 lead to missing pages. After: all 91 resolve.pnpm dev, each of the four URLs above returns 301 and the final page returns 200.pnpm check:types,pnpm check:linton the file, andprettier --checkpass.Related issues & labels