Repository navigation
Remove the generated changelog PR from the publish workflow - #59172
Open
fabriziocucci wants to merge 1 commit into
Open
fabriziocucci wants to merge 1 commit into
fabriziocucci wants to merge 1 commit into
Conversation
The release copilot opens the changelog PR now, curated, so the generate_changelog job and its script are no longer needed. create_draft_release depended on that job only for ordering, so it now depends on publish_react_native directly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes the
generate_changelogjob from the publish workflow, along withgenerate-changelog.yml,generateChangelog.jsand its test.The job opened a
changelog/v<version>PR with every section present, empty or not, anUnknownbucket and the release machinery's own commits in it. Every one was then curated by hand. The release copilot (reactwg/react-native-releases#1425) now opens that PR itself. It runs the same@rnx-kit/rn-changelog-generatoragainst the same base, drops the machinery commits, sorts by scope and omits empty sections. It also opens the.0consolidation, which the job always skipped (0.88's was #59122, done by hand).create_draft_releaselistedgenerate_changeloginneedsand itsif. It depended on it for ordering only:createDraftRelease.jsrunsgit checkout -b changelog/v<version>, which creates a new local branch from the tag and never reads the bot's branch. The tag's ownCHANGELOG.mdnever carries the release's section (checked for v0.88.0-rc.4, v0.88.0-rc.6 and v0.87.1), which is why the draft notes have always come out empty. It now depends onpublish_react_nativedirectly, so it still runs only after a successful publish.The publish workflow runs from the tag's branch, so this takes effect from the first branch cut after it lands. Existing
*-stablebranches keep the job unless this is picked. The copilot defers to the bot wherever the job is still present, so the two never open the same branch.This should land after reactwg/react-native-releases#1425, since that is where the replacement lives.
Changelog:
[INTERNAL] [REMOVED] - Remove the generated changelog PR from the publish workflow
Test Plan:
yarn jest .github/workflow-scripts: 10 suites, 61 tests pass..github/workflowsparses as YAML. Inpublish-npm.yml, everyneedsentry names an existing job and nothing referencesgenerate_changelog.git grepforgenerate_changelog,generate-changelogandgenerateChangelogfinds nothing under.githubafter the change.