Repository navigation
Defer EntryPoint value validation until loading - #547
Open
rudra337-lgtm wants to merge 1 commit into
Open
rudra337-lgtm wants to merge 1 commit into
rudra337-lgtm wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #523.
EntryPoint.__init__previously parsed and validatedvalueimmediately. Sinceentry_points(group=...)constructs entries before applying the group filter, one malformed entry in an unrelated group could prevent callers from retrieving valid entries. Defer parsing until a component is accessed orload()is called; malformed entries still raiseValueErrorwhen used.The regression test creates a distribution with a valid selected group and an invalid unselected group, verifies selection succeeds, and verifies loading the invalid entry still raises
ValueError.Validation:
tests/test_api.py: 38 passed, 39 subtests passed.TestEntryPointsunit tests: 8 passed.git diff --checkpassed.AI assistance was used to prepare and validate this change; the reported checks were run locally.