Repository navigation
Require complete bytes in Base16 validation - #517
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
Author
|
Could a maintainer approve the pending CI runs and review this PR for merging? Local tests, doctests, Ruff, and strict Pyright all pass. Thank you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base16("ABC")currently succeeds even though the value contains only one and a half encoded bytes and Python's Base16 decoder rejects it. Require complete pairs of hexadecimal characters while retaining lowercase support and the existing empty-input behavior.RFC 4648 section 8 encodes each byte as two Base16 characters. This deliberately tightens validation for odd-length hexadecimal strings, which were previously accepted.
Five new regressions fail on master and pass with this change. Full tests including doctests pass on Python 3.12 (1,176 passed). Ruff lint/format checks and strict Pyright pass with zero diagnostics. Other Python versions are left to CI.
Prepared with AI assistance; reproduced and tested locally.