Repository navigation
test(pay): 补充应答时间戳校验回归覆盖 - #4142
binarywang wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
变更仅涉及确定性测试,断言与现有校验契约一致,未发现阻止合并的问题;本次未运行测试。
No open issues 🎉
What changed in this PR
为 #4137 引入的支付 V3 应答时间戳校验补充回归测试,不修改生产代码或依赖。
Changes:
- 使用计数验签器验证验签结果及时间戳拒绝时的短路行为。
- 覆盖 ±301 秒、极值、溢出字符串、空白输入和负容差。
- 使用可推进时钟验证 300 秒边界及其后的过期行为,无新增 sleep。
| File | Description |
|---|---|
| weixin-java-pay/src/test/java/com/github/binarywang/wxpay/v3/auth/WxPayValidatorTest.java | 补充时间戳边界、异常输入及验签调用回归覆盖。 |
Review effort: Balanced
🤖 Augment PR Summary本 PR 仅扩展 🤖 Was this summary useful? React with 👍 or 👎 |
Summary
补充已合并 #4137 的支付应答时间戳回归覆盖,避免新鲜度检查掩盖验签结果或遗漏边界条件。
使用计数验签器和确定性时钟,无新增 sleep;仅修改测试,生产行为保持不变,包括证书刷新与非 JSON 应答处理。
Evidence
After: 聚焦测试 24 项、支付离线套件 205 项、common 28 项全部通过,0 失败、0 错误、0 跳过;
git diff --check通过。CircleCI #1453 在提交
fc87e3c8886d768e8b87a051fc54053bfe234bd8上成功。未执行全仓库测试;上述结果不代表真实 JDK 8 运行时验证。Merge Danger
Door: two-way
可直接回退的测试变更。
Blast Radius: tests
仅影响支付模块测试覆盖,不修改生产代码或依赖。