Repository navigation
[Fix][#18160] Prevent NPE in SessionConnection when query response is null - #18903
Open
AdamsF-creator wants to merge 1 commit into
Open
AdamsF-creator wants to merge 1 commit into
AdamsF-creator wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18160
Content1: Background & Problem
When executing queries via
SessionConnection, if the RPC layer or network retry fails to obtain a valid response from the server,result.getResult()can benull. The client previously invokedexecResp.getStatus()directly without verifying ifexecRespwas null, leading to an unexpectedNullPointerException(NPE) rather than a descriptive connection exception.Content2: Defensive Null Check & Exception Handling
Added defensive null-checks for
execResp/tsExecuteStatementRespacross all relevant query methods (executeQueryStatement,executeRawDataQuery,executeLastDataQuery,executeLastDataQueryForOneDevice,executeLastDataQueryForOnePrefixPath, andexecuteAggregationQuery) inSessionConnection.java. When anullresponse is encountered, it now explicitly throws anIoTDBConnectionException("Cannot get statement response from server, response is null")to clearly indicate a communication failure.Content3: Unit Test & Verification
Added a corresponding unit test
testExecuteQueryStatementNullResponseinSessionConnectionTest.javaby mockingIClientRPCService.Ifaceto returnnull. Verified thatSessionConnectionthrowsIoTDBConnectionExceptioninstead of crashing with an NPE.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
org.apache.iotdb.session.SessionConnectionorg.apache.iotdb.session.SessionConnectionTest